🐛 Fix SIGSERV when RawSpec is nil (due to anonymous struct) #892
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
Welcome @rkettelerij! |
k8s-ci-robot
added
the
needs-ok-to-test
|
Hi @rkettelerij. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rkettelerij The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/XS
| if ctx.info.RawSpec.Type != structType { | ||
| if ctx.info.RawSpec != nil && ctx.info.RawSpec.Type != structType { |
There was a problem hiding this comment.
Hi, I've managed to break the complex set of structs down to the following test case. controller-get crd paths="<path/to/testcase/below>/..." output:stdout currently fails on this one. With the fix it doesn't fail. It's due to the use of an anonymous struct.
// +groupName=test
package config
import (
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
)
type ExampleSpec struct {
Service Service `json:"service"`
}
type Example struct {
metav1.TypeMeta `json:",inline"`
metav1.ObjectMeta `json:"metadata,omitempty"`
Spec ExampleSpec `json:"spec,omitempty"`
}
type Service struct {
// +optional
Foobar struct {
// placeholder
} `yaml:"foobar" json:"foobar"`
}
There was a problem hiding this comment.
@rkettelerij please update pkg/crd/testdata/cronjob_types.go with an anonymous struct to test this
/ok-to-test
rkettelerij
changed the title
k8s-ci-robot
added
ok-to-test
|
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
k8s-ci-robot
added
the
lifecycle/stale
|
@rkettelerij Do you have time to address the finding? |
|
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
k8s-ci-robot
added
lifecycle/rotten
|
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close |
|
@k8s-triage-robot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Under some circumstances
RawSpeccan be nil. I've encountred this when generating a CRD of a complex set of structs. Currently thestructToSchemafunc fails hard on this (SIGSERV). This PR fixes the latter.